Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty metrics due to prom-client@13 #296

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix empty metrics due to prom-client@13 #296

merged 1 commit into from
Jan 22, 2021

Conversation

Half-Shot
Copy link
Contributor

No description provided.

@Half-Shot Half-Shot requested a review from a team January 15, 2021 13:44
@Half-Shot Half-Shot mentioned this pull request Jan 15, 2021
Merged
jaller94
jaller94 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uff, nice catch

I confirmed on https://www.npmjs.com/package/prom-client that all examples use the function with await.

@Half-Shot Half-Shot merged commit dfaf4a0 into develop Jan 22, 2021
@jaller94 jaller94 deleted the hs/metrics-is-async branch January 25, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @jaller94