Prefer server-level display names when available #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheStranjer
force-pushed
the
prefer-guild-nick
branch
6 times, most recently
from
57a2bfe
to
1f98718
Compare
Signed-off-by: Bob Arctor <neetzsche@tutanota.com>
TheStranjer
force-pushed
the
prefer-guild-nick
branch
from
1f98718
to
17ebb66
Compare
AndrewFerr
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes server-level displayName values don't propagate correctly onto Matrix. This fixes that. Apparently you can't get the user-level display name in DiscordJS yet except in the dev version, and you're on a fork of a fork of a fork of that so I'm just no messing with it.
Signed-off-by:
Bob Arctor <neetzsche@tutanota.com>