Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enure CTCP from address is valid #1053

Merged
merged 2 commits into from
May 19, 2020
Merged

Enure CTCP from address is valid #1053

merged 2 commits into from
May 19, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #1051

@Half-Shot Half-Shot requested a review from a team May 12, 2020 19:38
jaller94
jaller94 approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something we should do in the case that from is not defined?
e.g. log that a weird message was received

src/irc/ConnectionInstance.ts
@@ -330,7 +330,9 @@ export class ConnectionInstance {

private listenForCTCPVersions() {
this.client.addListener("ctcp-version", (from: string) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If string can be falsey, this signature is incorrect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing the signature?
This from: string should likely be from: string|undefined or ``from: string|null`.

@Half-Shot Half-Shot merged commit f495f04 into develop May 19, 2020
@jaller94 jaller94 deleted the hs/ctcp-from-address branch May 19, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @jaller94