Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge crashes after significant QUIT buildup #1090

Closed
Half-Shot opened this issue Jul 25, 2020 · 3 comments
Closed

Bridge crashes after significant QUIT buildup #1090

Half-Shot opened this issue Jul 25, 2020 · 3 comments
Labels

Comments

@Half-Shot
Copy link
Contributor

The bridge has recently started to crash more after it sees enough QUITs that it gets horribly backed up in requests, and is quickly killed. The logging doesn't suggest much other than a huge amount of quits happening in a short space of time.

We have the QuitDebouncer which runs inside the IRCHandler, which would hopefully take care of the increase however it doesn't appear to be having much effect.

@Half-Shot
Copy link
Contributor Author

Having thoughts on this, we might be debouncing too late and too inefficiently. The solution may be to deliberately drop QUITs to the floor as soon as we see them and as soon as we are above a threshold. Perhaps we could even store a set of channels we have seen a QUIT from, and then mark them as requiring a names refresh once the netsplit is over.

@Half-Shot
Copy link
Contributor Author

The proposed solution is #1091

@Half-Shot
Copy link
Contributor Author

We've not seen issues since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant