Correct nick validation #1114
Merged
Correct nick validation #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for easier unit testing. Tests were not added for the "nick must start with a letter" condition, because this will be changed in the next commit. Signed-off-by: Dexter Chua <dec41@srcf.net>
According to RFC 2812 § 2.3.1 is allowed to start with either a letter or a special character. Previously, this followed the older RFC 1459 that only allowed letters (but the rest of the logic follows RFC 2812). Fixes matrix-org#467 Signed-off-by: Dexter Chua <dec41@srcf.net>
Half-Shot
approved these changes
Aug 17, 2020
| describe("BridgedClient", function() { | ||
| describe("getValidNick", function() { | ||
| it("valid nick unchanged", function() { | ||
| expect(BridgedClient.getValidNick("foobar", true, STATE_DISC)).toBe("foobar"); |
There was a problem hiding this comment.
it would be good to have more valid examples here containing numbers and special characters
Half-Shot
reviewed
Aug 17, 2020
Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Will Hunt <will@half-shot.uk>
Co-authored-by: Will Hunt <will@half-shot.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 2812 § 2.3.1 is allowed to start with either a letter or a
special character. Previously, this followed the older RFC 1459 that only
allowed letters (but the rest of the logic follows RFC 2812).
Fixes #467. Supersedes #552.