Cache MODE -> power level changes before applying #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested review from
a team and
jaller94
and removed request for
a team
jaller94
approved these changes
Nov 12, 2020
Half-Shot
force-pushed
the
hs/cache-pls-for-a-bit
branch
from
ad02dfe
to
21f7435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180
If we see a lot of mode changes at once, the bridge will attempt to send one power level event for each. This PR will instead cache the power level changes for a short while in memory, and will apply them once the requests stop coming in. This is configurable in the config file, but defaults to 1 second.