Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclusively allow additional addresses when connecting to IRC #1376

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Exclusively allow additional addresses when connecting to IRC #1376

merged 3 commits into from
Jun 9, 2021

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jun 8, 2021 •
edited

This is so that we can connect to irc.matrix.libera.chat exclusively while retaining the same config key and name in bridge messages.

@Half-Shot Half-Shot requested a review from a team June 8, 2021 09:17
jaller94
jaller94 suggested changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces a runtime error if no addresses are in the addtionalAddresses list and onlyAdditionalAddresses is true.

src/irc/IrcServer.ts Show resolved Hide resolved
src/irc/IrcServer.ts Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from jaller94 June 9, 2021 09:44
jaller94
jaller94 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks all good to me now.

@Half-Shot Half-Shot merged commit 67f83b9 into develop Jun 9, 2021
@Half-Shot Half-Shot deleted the hs/additional-addresses-exclusive branch June 9, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @jaller94