Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MAB's UserActivityTracker and blocking the bridge upon exceeding the user limit #1472

Merged
merged 10 commits into from
Oct 8, 2021

Conversation

tadzik
Copy link
Collaborator

@tadzik tadzik commented Sep 2, 2021

Developed in tandem with matrix-org/matrix-appservice-bridge#350

@tadzik tadzik requested a review from a team September 2, 2021 14:01
@tadzik tadzik marked this pull request as draft September 2, 2021 14:01
@tadzik tadzik force-pushed the tadzik/rmau-limits branch 2 times, most recently from ecb39ca to a6daee0 Compare September 3, 2021 13:55
@tadzik tadzik marked this pull request as ready for review September 6, 2021 14:00
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns about this one

config.sample.yaml Show resolved Hide resolved
@Half-Shot
Copy link
Contributor

I believe we need #1453 for this to work?

@tadzik
Copy link
Collaborator Author

tadzik commented Sep 7, 2021

I believe we need #1453 for this to work?

I guess so – though locally I've also backported the MAB PR to the 2.6.1 that IRC bridge currently relies on, and it works too – we can use that if we're in a hurry.

@@ -131,6 +131,13 @@ properties:
type: "string"
RMAUlimit:
type: "integer"
userActivity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the sample config?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In in c0e3c2e

@Half-Shot Half-Shot merged commit b54eadc into develop Oct 8, 2021
@Half-Shot Half-Shot deleted the tadzik/rmau-limits branch October 8, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants