Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help not showing admin commands when the user is an admin #1478

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Fix help not showing admin commands when the user is an admin #1478

merged 3 commits into from
Sep 14, 2021

Conversation

Half-Shot
Copy link
Contributor

This was caused by us passing in the sender rather than the permission of the user.

I've fixed this by using an enum type for permissions, so we don't make the mistake of passing in a string and expecting it to work.

@Half-Shot Half-Shot requested a review from a team September 14, 2021 10:03
tadzik
tadzik approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm proper types

@Half-Shot Half-Shot merged commit 4302af1 into develop Sep 14, 2021
@Half-Shot Half-Shot deleted the hs/help-permissions branch September 14, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @tadzik