Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strongly typed emitters #1604

Merged
merged 8 commits into from
Sep 13, 2022
Merged

Strongly typed emitters #1604

merged 8 commits into from
Sep 13, 2022

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Sep 7, 2022 •
edited

The other side of matrix-org/node-irc#91. This ensures that the bridge is compatible with the type changes in matrix-org-irc

@Half-Shot Half-Shot changed the title Strongly typed emitters Draft: Strongly typed emitters Sep 7, 2022
@Half-Shot Half-Shot marked this pull request as draft September 7, 2022 22:06
@Half-Shot Half-Shot changed the title Draft: Strongly typed emitters Strongly typed emitters Sep 7, 2022
@Half-Shot Half-Shot marked this pull request as ready for review September 8, 2022 13:22
@Half-Shot Half-Shot requested a review from a team as a code owner September 8, 2022 13:22
tadzik
tadzik approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but CI seems unhappy.

@Half-Shot Half-Shot merged commit 9a75c32 into develop Sep 13, 2022
@Half-Shot Half-Shot deleted the hs/typed-emitters branch September 13, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @tadzik