Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor provisioning API #1655

Merged
merged 35 commits into from
Feb 8, 2023
Merged

Refactor provisioning API #1655

merged 35 commits into from
Feb 8, 2023

Conversation

justinbot
Copy link
Contributor

(Much of these changes derived from #1508)

Makes significant updates to the Provisioning API implementation, namely refactoring to use the ProvisioningApi class from matrix-appservice-bridge.

Also implements request validation and consistent error handling across the API.

@justinbot justinbot requested a review from a team as a code owner January 10, 2023 23:44
@justinbot justinbot self-assigned this Jan 10, 2023
@justinbot justinbot force-pushed the justinbot/provisioner-bridge-sdk branch 2 times, most recently from f2e0c83 to ea61853 Compare January 12, 2023 15:36
Half-Shot
Half-Shot reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing here is really jumping out at me as obviously bad so far 👍 . Suggest continuing to crack on with the widget development (in a child PR?) and circling back to the tests here afterwards.

src/provisioning/Provisioner.ts Outdated Show resolved Hide resolved
@justinbot justinbot force-pushed the justinbot/provisioner-bridge-sdk branch from b619e23 to c88956e Compare January 20, 2023 20:11
@justinbot justinbot mentioned this pull request Jan 23, 2023
Merged
@justinbot justinbot mentioned this pull request Jan 24, 2023
Closed
tadzik
tadzik approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's gonna look like I didn't even read it – but it does look good to me!

Half-Shot
Half-Shot approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy happy from my PoV

@matrix-org matrix-org deleted a comment Feb 6, 2023
@justinbot justinbot merged commit 3158cc5 into develop Feb 8, 2023
@justinbot justinbot deleted the justinbot/provisioner-bridge-sdk branch February 8, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

@tadzik tadzik tadzik approved these changes

Assignees

@justinbot justinbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinbot @tadzik @Half-Shot