Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hot-reloading of the bridge logger #1704

Merged
merged 3 commits into from Apr 27, 2023
Merged

Allow hot-reloading of the bridge logger #1704

merged 3 commits into from Apr 27, 2023

Conversation

Half-Shot
Copy link
Contributor

We already had it for the matrix-appservice-bridge logger but not the legacy logger. At some point we need to remove it, but for now this will do.

@Half-Shot Half-Shot requested a review from a team as a code owner April 26, 2023 11:14
AndrewFerr
AndrewFerr approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough

@Half-Shot Half-Shot merged commit a750678 into develop Apr 27, 2023
9 checks passed
@Half-Shot Half-Shot deleted the hs/allow-configuring-logging branch April 27, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @AndrewFerr