Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove statsd #949

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Remove statsd #949

merged 4 commits into from
Jan 21, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #818

We don't use this in production, and nobody else really seemed that keen either. Removing it saves us a bit of maintenance work.

Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Half-Shot Half-Shot requested review from benparsons and a team January 21, 2020 13:57
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so.

If you only need review from one person it's generally best to not re-request the whole team.

@@ -0,0 +1 @@
Remove `statsd` support as per #818
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably need a real link to work

@Half-Shot
Copy link
Contributor Author

If you only need review from one person it's generally best to not re-request the whole team.

The person in question isn't around for a while, and the changes were sufficient that it needed a re-review.

@Half-Shot Half-Shot merged commit aa8d3fa into develop Jan 21, 2020
@jaller94 jaller94 deleted the hs/remove-statsd branch April 2, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants