Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking in messages not present in Slack #292

Closed
joenas opened this issue Oct 7, 2019 · 8 comments
Closed

Linking in messages not present in Slack #292

joenas opened this issue Oct 7, 2019 · 8 comments
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@joenas
Copy link

joenas commented Oct 7, 2019

Message:

{
  "type": "m.room.message",
  "sender": "@user:matrix.org",
  "content": {
    "body": "[link](https://jonnev.se)",
    "format": "org.matrix.custom.html",
    "msgtype": "m.text",
    "formatted_body": "<a href=\"https://jonnev.se\">link</a>"
  },
}

Screenshot 2019-10-07 at 11 26 07

Screenshot 2019-10-07 at 11 29 04

@joenas
Copy link
Author

joenas commented Oct 7, 2019

I also have another example where the message is a notice (using that to not trigger notifications in Riot when posting as a bot)

{
  "type": "m.room.message",
  "content": {
    "body": "Solving all 42 versions of the Harry Potter potions puzzle (comments)",
    "msgtype": "m.notice",
    "format": "org.matrix.custom.html",
    "formatted_body": "<a href='https://kevingal.com/blog/potter-puzzle.html'>Solving all 42 versions of the Harry Potter potions puzzle</a> (<a href='https://www.reddit.com/r/programming/comments/deauxe/solving_all_42_versions_of_the_harry_potter/'>comments</a>)"
  },
}

@Half-Shot
Copy link
Contributor

Will be fixed by #280

@joenas
Copy link
Author

joenas commented Oct 7, 2019

Including the m.notice thing @Half-Shot ?

@Half-Shot
Copy link
Contributor

Nope, but that's a separate issue. We don't currently parse HTML from messages at all, so it won't be bridged. You should open a new issue for that though.

@auscompgeek
Copy link
Contributor

Just tested with the matrix.org instance. I now only see the URL, the link text is discarded.

@Half-Shot
Copy link
Contributor

@joenas
Copy link
Author

joenas commented Oct 12, 2019

It works the other way around so I solved it that way for now! Sending formatted Slack links converts properly in Matrix 👌🏻

@jaller94
Copy link
Contributor

Fixed by #280

@jaller94 jaller94 added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

4 participants