Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify path of config.yml in the docs #364

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Clarify path of config.yml in the docs #364

merged 3 commits into from
Mar 18, 2020

Conversation

jaller94
Copy link
Contributor

I got confused by the path of step 3 including the config/ folder, but config.yaml not including the folder name.
When they both include the folder name, it's easier to tell where the new file should be placed.

I got confused by the path of step 3 including the `config/` folder, but `config.yaml` not including the folder name.
When they both include the folder name, it's easier to tell where the new file should be placed.
@jaller94
Copy link
Contributor Author

jaller94 commented Mar 18, 2020

Actually, config.yaml (not inside the config folder) was right for the Node command.
For the Docker instructions config/config.yaml is correct.

I suggest to always use config/config.yaml.

@jaller94 jaller94 requested a review from Half-Shot March 18, 2020 15:10
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to unify docker and non-docker deployments. LGTM

@jaller94 jaller94 merged commit 8dacf71 into develop Mar 18, 2020
@jaller94 jaller94 deleted the jaller94-patch-1 branch March 18, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants