Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct ISlackEvent.user type #374

Merged
merged 7 commits into from
Mar 23, 2020
Merged

Correct ISlackEvent.user type #374

merged 7 commits into from
Mar 23, 2020

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Mar 20, 2020 •
edited

Fixes #373

Depending on the event type user is:

  • undefined,
  • an id string or
  • an ISlackUser (e.g. for the type user_change).

@jaller94 jaller94 self-assigned this Mar 20, 2020
@jaller94 jaller94 changed the title Correct ISlackEvent.user type Correct ISlackEvent.user type; remove unused declarations Mar 20, 2020
@jaller94 jaller94 changed the title Correct ISlackEvent.user type; remove unused declarations Correct ISlackEvent.user type Mar 20, 2020
@jaller94 jaller94 requested a review from Half-Shot March 20, 2020 12:58
Half-Shot
Half-Shot requested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing about the comments, but otherwise this looks good. Thanks :)

src/SlackEventHandler.ts Outdated Show resolved Hide resolved
@jaller94 jaller94 requested a review from Half-Shot March 20, 2020 15:32
@jaller94 jaller94 assigned Half-Shot and unassigned jaller94 Mar 23, 2020
@jaller94 jaller94 merged commit 45dda5e into develop Mar 23, 2020
@jaller94 jaller94 deleted the j94/types branch March 23, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type annotation for user on ISlackEvent
2 participants
@jaller94 @Half-Shot