Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user_change to the list of supported events #377

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Add user_change to the list of supported events #377

merged 3 commits into from
Mar 20, 2020

Conversation

jaller94
Copy link
Contributor

We are not actually listening to user_change events, so when a Slack user updates their display name, it does not get replicated to Matrix.

matrix-appservice-slack/src/SlackRTMHandler.ts

Lines 148 to 150 in a2488ff

// For each event that SlackEventHandler supports, register
// a listener.
SlackEventHandler.SUPPORTED_EVENTS.forEach((eventName) => {

This PR add user_change to the list of supported events which determines what Slack events we listen to.

name change-in-matrix

@jaller94 jaller94 requested a review from Half-Shot March 20, 2020 14:48
Half-Shot
Half-Shot reviewed Mar 20, 2020
View reviewed changes
changelog.d/377.bug Outdated Show resolved Hide resolved
@jaller94 jaller94 requested a review from Half-Shot March 20, 2020 15:16
Half-Shot
Half-Shot approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass 👍

@jaller94 jaller94 merged commit ed8de3b into develop Mar 20, 2020
@jaller94 jaller94 deleted the j94/listen-to-user_change branch March 20, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaller94 @Half-Shot