Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send error if HTTP connection is closed #392

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Do not send error if HTTP connection is closed #392

merged 3 commits into from
Apr 16, 2020

Conversation

Half-Shot
Copy link
Contributor

Fixes #359

@Half-Shot Half-Shot requested a review from a team April 14, 2020 14:45
jaller94
jaller94 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks functionally safe, but an inline comment or two would help to see what is being prevented.

src/SlackHookHandler.ts Show resolved Hide resolved
@Half-Shot Half-Shot merged commit 0251ad4 into develop Apr 16, 2020
@jaller94 jaller94 deleted the hs/fix-req-throw branch April 16, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error [ERR_STREAM_WRITE_AFTER_END] caused bridge crash on SlackHookHandler.handleEvent
2 participants
@Half-Shot @jaller94