Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently suggest to use port 5858 for the appservice #436

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Consistently suggest to use port 5858 for the appservice #436

merged 2 commits into from
Jul 22, 2020

Conversation

jaller94
Copy link
Contributor

Our Docker image uses port TCP 5858, so we may as well suggest it as the appservice port consistently.

@jaller94 jaller94 requested a review from a team July 21, 2020 17:40
Half-Shot
Half-Shot approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout. LGTM

@jaller94 jaller94 merged commit 206b3a0 into develop Jul 22, 2020
@jaller94 jaller94 deleted the j94/consistent-appservice-port branch July 22, 2020 13:18
@debuggingfuture debuggingfuture mentioned this pull request Mar 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaller94 @Half-Shot