Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print the correct appservice port on the console when using the one from the config #440

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Print the correct appservice port on the console when using the one from the config #440

merged 2 commits into from
Jul 23, 2020

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Jul 23, 2020 •
edited

Fixes #441

The CLI class expects its port to be used but the bridge may override that with an optional value from the config.

Only affects console output. The behaviour was not actually broken.

@jaller94 jaller94 changed the title Print the correct port on the console Print the correct appservice port on the console when using the one from the config Jul 23, 2020
@jaller94 jaller94 requested a review from a team July 23, 2020 14:37
@jaller94 jaller94 added the bug label Jul 23, 2020
Half-Shot
Half-Shot approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaller94 jaller94 merged commit 833b295 into develop Jul 23, 2020
@jaller94 jaller94 deleted the j94/fix-wrong-port-in-log branch July 23, 2020 14:58
@jaller94 jaller94 added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. and removed bug labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Matrix-side listening on port X" can be incorrect
2 participants
@jaller94 @Half-Shot