Fixes the admin command "help oauth" and better types for AdminCommands #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
changed the title
jaller94
changed the title
jaller94
changed the title
jaller94
commented
Jul 23, 2020
| if (command) { | ||
| const cmd = this[command as string] as AdminCommand; | ||
| const cmd = this.commands.find((adminCommand) => (adminCommand.command.split(' ')[0] === command)); |
There was a problem hiding this comment.
This is the line that fixes the help oauth and protects against calling .detailedDescription() on other class members.
jaller94
added
the
T-Defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #443
Before
help foosearched for a methodfooon AdminCommands.help oauthwas broken, because the method has a different name.But other class methods could be called, even though they are not admin commands.
Other examples like this:
help yargs,help commands,help constructor,help __prototype__. 😐️I haven't found any security issues or ways to crash the bridge with to this, however, I think this PR mitigates the risk that there is a way to exploit this.
After