Correctly bubble up rejected promises from TeamSync #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating promises could lead to uncaught errors in TeamSync
Failing user or channel syncs are currently resulting in an uncaught promise. That a deprecated functionality of Node, which will crash the end the process soon anyway and would lead to inconsistent behaviour.
.setAvatarUrl threw because Synapse doesn't like undefined
Also, .setAvatarUrl requires a string. The Element client resets the avatar by providing an empty array, so this fixes #453.
Broken counter for creating team clients
outputs
because at the time the promises execute, the variable
i
from the outer context already has its final value 3.