Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump matrix-appservice-bridge@1.13.2 #459

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Bump matrix-appservice-bridge@1.13.2 #459

merged 2 commits into from
Aug 13, 2020

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Aug 12, 2020 •
edited

in 1.13.1 we were returning undefined for sendEvent which was causing issues inserting events into the DB, in turn causing #452

@Half-Shot Half-Shot requested a review from a team August 12, 2020 18:16
jaller94
jaller94 approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Half-Shot
Copy link
Contributor Author

(the linting was fixed in another PR)

@Half-Shot Half-Shot merged commit 38e2800 into develop Aug 13, 2020
@jaller94 jaller94 deleted the hs/fix-thread-bug branch August 13, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @jaller94