Minimize docker build time #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
reviewed
Oct 9, 2020
changelog.d/531.feat
Outdated
| @@ -0,0 +1 @@ | |||
| Allow docker to reuse cache when building the image by copying only npm related file before running `npm install` | |||
Half-Shot
reviewed
Oct 9, 2020
Half-Shot
reviewed
Oct 9, 2020
We copy only npm related files first, so we can use the cache and not run again `npm install` when only the code changes. Signed-off-by: Alexandre Morignot <erdnaxeli@cervoi.se>
Half-Shot
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We copy only npm related files first, so we can use the cache and not run again
npm installwhen only the code changes.Signed-off-by: Alexandre Morignot erdnaxeli@cervoi.se
This speeds up a bit development time, when using the docker image to test (as I do).