Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only encrypt private rooms #576

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Only encrypt private rooms #576

merged 2 commits into from
Mar 16, 2021

Conversation

Half-Shot
Copy link
Contributor

We should never have encrypted public rooms

@Half-Shot Half-Shot requested a review from jaller94 March 10, 2021 10:59
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good short-term mitigation of errors.
However, I think that there are valid use cases for encryption of public rooms, e.g. room is "public" but restricted to a closed homeserver.

@Half-Shot
Copy link
Contributor Author

However, I think that there are valid use cases for encryption of public rooms, e.g. room is "public" but restricted to a closed homeserver.

This is the automatic encryption system. You can of course manually encrypt rooms yourself by toggling the bit.

@Half-Shot Half-Shot merged commit 838ac37 into develop Mar 16, 2021
@jaller94 jaller94 deleted the hs/encrypt-private-rooms branch March 16, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants