Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two main reasons why admin commands got stuck are:
yargs.parse
multiple times apparently doesn't behave well when command handlers return a Promise:yargs.parse
throws, or the callback given to it throws,yargs.argv
is permanently set to aYError
, and all future calls toyargs.parse
throw that same error.This PR cleans up some of our
yargs
usage & moves all asynchronicity of command callbacks outside ofyargs.parse
.