Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Docker container uses port 5858 unless explicitly modified in config.yaml #718

Closed
wants to merge 1 commit into from
Closed

Docs: Docker container uses port 5858 unless explicitly modified in config.yaml #718

wants to merge 1 commit into from

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Nov 18, 2022

No description provided.

@mkarg mkarg requested a review from a team as a code owner November 18, 2022 21:54
jaller94
jaller94 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I don't see a sign-off nor a file in changelog.d.

@mkarg mkarg changed the title Docker container uses port 5858 unless explicitly modified in config.yaml Docs: Docker container uses port 5858 unless explicitly modified in config.yaml Nov 26, 2022
@mkarg
Copy link
Contributor Author

mkarg commented Nov 26, 2022

Changes look good.

I don't see a sign-off nor a file in changelog.d.

Just fixed both, please kindly reconsider this PR. Thanks. :-)

@mkarg
Docker container uses port 5858 unless explicitly modified in config.…
1e93bac 
…yaml

Signed-off-by: Markus KARG <markus@headcrashing.eu>
@Half-Shot Half-Shot deleted the branch matrix-org:master November 30, 2022 15:11
@Half-Shot Half-Shot closed this Nov 30, 2022
jaller94 pushed a commit that referenced this pull request Nov 30, 2022
https://github.com/matrix-org/matrix-appservice-slack/pull/718
3d0ab6d
@jaller94 jaller94 mentioned this pull request Nov 30, 2022
Merged
jaller94 pushed a commit that referenced this pull request Dec 2, 2022
Revert "#718"
f0c4375 
This reverts commit 3d0ab6d.
jaller94 pushed a commit that referenced this pull request Dec 2, 2022
@mkarg
https://github.com/matrix-org/matrix-appservice-slack/pull/718
ec7aae2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkarg @jaller94 @Half-Shot