Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixed numbering by fixing indentation #719

Closed
wants to merge 1 commit into from

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Nov 18, 2022

The original page stopped numbering at #7 then started with #1 again. The sole cause was that the indentation of the code blocks was incorrect. By fixing the indentation of the code blocks, the numbering now correctly goes 7, 8, 9, 10.

@mkarg mkarg requested a review from a team as a code owner November 18, 2022 21:58
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I don't see a sign-off nor a file in changelog.d.

@mkarg
Copy link
Contributor Author

mkarg commented Nov 26, 2022

Changes look good.

I don't see a sign-off nor a file in changelog.d.

Just fixed both, please kindly reconsider this PR. Thanks. :-)

Is that needed / beneficial for such a simple whitespace-only fix?

@mkarg mkarg changed the title Fixed numbering by fixing indentation Docs: Fixed numbering by fixing indentation Nov 26, 2022
Signed-off-by: Markus KARG <markus@headcrashing.eu>
@Half-Shot Half-Shot deleted the branch matrix-org:master November 30, 2022 15:11
@Half-Shot Half-Shot closed this Nov 30, 2022
@jaller94 jaller94 mentioned this pull request Nov 30, 2022
jaller94 pushed a commit that referenced this pull request Dec 2, 2022
This reverts commit d51f963.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants