Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify /whoami endpoint supports AppServices #1135

Closed
anoadragon453 opened this issue Mar 2, 2018 · 3 comments
Closed

Specify /whoami endpoint supports AppServices #1135

anoadragon453 opened this issue Mar 2, 2018 · 3 comments

Comments

@anoadragon453
Copy link
Member

It's easy to forget that application services must also be supported by the /whoami GET API endpoint. A note should be added to the spec to remind the user that this is the case.
@anoadragon453 anoadragon453 mentioned this issue Mar 2, 2018
Closed
3 tasks
@turt2live
Copy link
Member

ftr this means that ?user_id=@_freenode_whatever:matrix.org gives {"user_id":"@_freenode_whatever:matrix.org"} - assuming the proper access checks pass, of course.

@jevolk
Copy link
Contributor

jevolk commented Mar 5, 2018

These notices should probably be put on every endpoint where it applies. Already made a similar mistake in #1125.

turt2live added a commit to turt2live/matrix-doc that referenced this issue Mar 6, 2018
@turt2live
Improve documentation around /account/whoami
2e4e5e2 
Clarifies: matrix-org#1135

Signed-off-by: Travis Ralston <travpc@gmail.com>
@turt2live turt2live mentioned this issue Mar 6, 2018
Merged
@richvdh
Copy link
Member

richvdh commented Mar 7, 2018

clarified in #1152 thanks to @turt2live

@richvdh richvdh closed this as completed Mar 7, 2018
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this issue Aug 22, 2023
@bradtgmurray @richvdh @turt2live
Fix typo in m.secret.request device event name (matrix-org#1135)
ead4375 
* Fix typo in m.secret.request device event name

I don't think this is supposed to be plural according to the various SDKs

* Add changelog

* Update changelogs/client_server/newsfragments/1135.clarification

* Update changelogs/client_server/newsfragments/1135.clarification

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@turt2live @anoadragon453 @richvdh @jevolk