Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention that /sync and /events is special for AS user #1144

Closed
erikjohnston opened this issue Mar 5, 2018 · 1 comment
Closed

Mention that /sync and /events is special for AS user #1144

erikjohnston opened this issue Mar 5, 2018 · 1 comment
Assignees
@turt2live
Labels
application services clarification An area where the spec could do with being more explicit
Projects
August 2018 r0

Comments

@erikjohnston
Copy link
Member

Historically, an AS user could use /sync and /events to get all updates for all rooms that they are "interested in". This functionality has been deprecated for a long time due to performance issues, and in fact its has been broken in synapse for a while. The plan is for this to be removed from future versions of synapse.

We should mention that /sync and /events won't work for AS users (but will for AS virtual users).

Alternatively, we could look to make /sync to work as usual for AS users, meaning no special documentation would be needed in the spec (apart from mentioning the change).
erikjohnston added a commit to matrix-org/synapse that referenced this issue Mar 5, 2018
@erikjohnston
Remove ability for AS users to call /events and /sync
d4ffe61 
This functionality has been deprecated for a while as well as being
broken for a while. Instead of fixing it lets just remove it entirely.

See: matrix-org/matrix-spec-proposals#1144
@erikjohnston erikjohnston mentioned this issue Mar 5, 2018
Merged
@richvdh
Copy link
Member

richvdh commented Mar 6, 2018

Let's assume we're doing option 1 for now.

@richvdh richvdh added the clarification An area where the spec could do with being more explicit label Mar 6, 2018
@transamerican transamerican mentioned this issue May 20, 2018
Closed
@turt2live turt2live mentioned this issue Jun 9, 2018
Closed
@turt2live turt2live added this to To do: appservices (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live self-assigned this Aug 17, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 17, 2018
@turt2live
Add a note that application services cannot /sync normally
205b326 
Fixes matrix-org#1144
@turt2live turt2live mentioned this issue Aug 17, 2018
Merged
@turt2live turt2live moved this from To do: appservices (prioritized) to In review in August 2018 r0 Aug 17, 2018
August 2018 r0 automation moved this from In review to Done (this list will be incomplete) Aug 20, 2018
@jgoerzen jgoerzen mentioned this issue Apr 13, 2020
Closed
@theCalcaholic theCalcaholic mentioned this issue Dec 21, 2020
Closed
@Torxed Torxed mentioned this issue Feb 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
application services clarification An area where the spec could do with being more explicit
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @richvdh @erikjohnston