Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Querying a field on a user's profile for a user that does not exist should return 404, not 200 #1434

Closed
turt2live opened this issue Jul 19, 2018 · 2 comments
Closed

Querying a field on a user's profile for a user that does not exist should return 404, not 200 #1434

turt2live opened this issue Jul 19, 2018 · 2 comments
Labels
improvement A suggestion for a relatively simple improvement to the protocol s2s Server-to-Server API (federation)

Comments

@turt2live
Copy link
Member

Currently the behaviour is to return an empty object when querying the profile of a user that does not exist over federation. This should be a 404 with M_NOT_FOUND.
@turt2live turt2live added improvement A suggestion for a relatively simple improvement to the protocol s2s Server-to-Server API (federation) labels Jul 19, 2018
@turt2live turt2live changed the title Querying the profile for a user that does not exist should return a 404, not 200 Querying a field on a user's profile for a user that does not exist should return 404, not 200 Jul 19, 2018
@turt2live
Copy link
Member Author

This is actually a case of querying ?user_id=@does_not_exist:domain.com&field=also_does_not_exist

@turt2live turt2live mentioned this issue Jul 19, 2018
Closed
turt2live added a commit to turt2live/matrix-doc that referenced this issue Jul 20, 2018
@turt2live
Combine all queries into their own section
f88173e 
This removes the Directory and Profile sections, instead opting to document them as Queries. 

The behaviour of profile queries is based on Synapse's behaviour. A few issues have been opened to improve the behaviour:
* matrix-org#1434
* matrix-org#1435
* https://github.com/matrix-org/matrix-doc/issues/1436
* https://github.com/matrix-org/matrix-doc/issues/1437

This fixes matrix-org#1404
@turt2live turt2live mentioned this issue Jul 20, 2018
Merged
@turt2live
Copy link
Member Author

This is essentially a subset of #1435 which is a synapse bug

turt2live added a commit to turt2live/matrix-doc that referenced this issue Jul 24, 2018
@turt2live
Combine all queries into their own section
1873f2a 
This removes the Directory and Profile sections, instead opting to document them as Queries. 

The behaviour of profile queries is based on Synapse's behaviour. A few issues have been opened to improve the behaviour:
* matrix-org#1434
* matrix-org#1435
* https://github.com/matrix-org/matrix-doc/issues/1436
* https://github.com/matrix-org/matrix-doc/issues/1437

This fixes matrix-org#1404
turt2live added a commit to turt2live/matrix-doc that referenced this issue Jul 26, 2018
@turt2live
Combine all queries into their own section
0ddf578 
This removes the Directory and Profile sections, instead opting to document them as Queries. 

The behaviour of profile queries is based on Synapse's behaviour. A few issues have been opened to improve the behaviour:
* matrix-org#1434
* matrix-org#1435
* https://github.com/matrix-org/matrix-doc/issues/1436
* https://github.com/matrix-org/matrix-doc/issues/1437

This fixes matrix-org#1404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement A suggestion for a relatively simple improvement to the protocol s2s Server-to-Server API (federation)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live