Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec include_all_networks and third_party_instance_id on federation and c2s /publicRooms #1476

Closed
turt2live opened this issue Aug 3, 2018 · 1 comment
Closed

Spec include_all_networks and third_party_instance_id on federation and c2s /publicRooms #1476

turt2live opened this issue Aug 3, 2018 · 1 comment
Labels
application services s2s Server-to-Server API (federation) spec-omission implemented but not currently specified
Projects
August 2018 r0

Comments

@turt2live
Copy link
Member

Both appear in the query string. include_all_networks is a boolean, and third_party_instance_id is of the format "appservice_id|network_id" - unclear as to how someone gets the appservice ID.
@turt2live turt2live added spec-omission implemented but not currently specified application services s2s Server-to-Server API (federation) labels Aug 3, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 3, 2018
@turt2live
Document the /publicRooms endpoint for federation
2ac80d3 
This intentionally doesn't document the third party network aspect of the endpoint. This is scheduled for a later area for dealing with third party network/IDs and is reported as matrix-org#1476

The client-server response has been broken out to a shared file: both the client-server and server-server /publicRoom endpoints return the same thing, with slightly different inputs.

The inputs (and behaviour) are based upon the docstring here: https://github.com/matrix-org/synapse/blob/43ecfe0b1028fea5e4dda197f5631aed67182ee6/synapse/federation/transport/server.py#L583-L612
This was referenced Aug 3, 2018
Merged
Closed
@turt2live turt2live added this to To do: cross-cutting/misc (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live
Copy link
Member Author

Duplicate of #869

@turt2live turt2live marked this as a duplicate of #869 Aug 23, 2018
August 2018 r0 automation moved this from To do: cross-cutting/misc (prioritized) to Done (this list will be incomplete) Aug 23, 2018
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this issue Aug 22, 2023
@richvdh
Cleanups to github actions workflow (matrix-org#1476)
ac8d34b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
application services s2s Server-to-Server API (federation) spec-omission implemented but not currently specified
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live