Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Content-Type header on non-GET federation request #1713

Closed
babolivier opened this issue Nov 9, 2018 · 0 comments · Fixed by #2086
Closed

Add Content-Type header on non-GET federation request #1713

babolivier opened this issue Nov 9, 2018 · 0 comments · Fixed by #2086
Assignees
@turt2live
Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)
Projects
Superceded by https://github.com/orgs... Matrix 1.0 workflow

Comments

@babolivier
Copy link
Contributor

Non-GET requests should have a Content-Type header (with application/json as its value). Although this is mentioned in the client-server API spec, it is missing from the federation one.
@turt2live turt2live added clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation) s2s r0 labels Nov 9, 2018
@neilisfragile neilisfragile added r0 P2 and removed r0 P1 labels Jan 7, 2019
@turt2live turt2live added this to Nice to have clarifications in Matrix 1.0 workflow May 25, 2019
@turt2live turt2live moved this from Clarifications TODO to To add to spec in Matrix 1.0 workflow Jun 3, 2019
@turt2live turt2live removed the r0 P2 label Jun 3, 2019
@turt2live turt2live moved this from To add to spec to In progress in Matrix 1.0 workflow Jun 6, 2019
@turt2live turt2live self-assigned this Jun 6, 2019
turt2live added a commit that referenced this issue Jun 6, 2019
@turt2live
Clarify that the default s2s transport is JSON over HTTP
500f3d3 
Fixes #1713
@turt2live turt2live mentioned this issue Jun 6, 2019
Merged
Matrix 1.0 workflow automation moved this from In progress to Done Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)
Projects
No open projects
Matrix 1.0 workflow
  
Done
Superceded by https://github.com/orgs...
  
To Do S2S
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify that the default s2s transport is JSON over HTTP matrix-org/matrix-spec-proposals
3 participants
@neilisfragile @turt2live @babolivier