Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients often can't detect a 404 on .well-known/matrix/client due to CORS #438

Open
aaronraimist opened this issue Feb 20, 2019 · 0 comments
Open

Clients often can't detect a 404 on .well-known/matrix/client due to CORS #438

aaronraimist opened this issue Feb 20, 2019 · 0 comments
Assignees
@turt2live
Labels
A-Client-Server Issues affecting the CS API wart A point where the protocol is inconsistent or inelegant

Comments

@aaronraimist
Copy link
Contributor

In practice (element-hq/element-web#7875) you often can't detect a 404 on a .well-known/matrix/client file because the default configurations of most web servers don't send CORS headers on errors.

I think this behavior could be improved by just changing the 3b check from

If the returned status code is not 200, or the response body is empty, then FAIL_PROMPT.

to

If the returned status code is not 200, or the response body is empty, then IGNORE.
@turt2live turt2live self-assigned this May 14, 2019
@turt2live turt2live mentioned this issue May 21, 2019
Merged
@turt2live turt2live added A-Client-Server Issues affecting the CS API wart A point where the protocol is inconsistent or inelegant labels May 28, 2019
@aaronraimist aaronraimist mentioned this issue Apr 13, 2020
Open
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Client-Server Issues affecting the CS API wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @aaronraimist