Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for PushCondition.kind is incorrect #1970

Closed
Sharparam opened this issue Apr 20, 2019 · 0 comments · Fixed by #2052
Closed

Documentation for PushCondition.kind is incorrect #1970

Sharparam opened this issue Apr 20, 2019 · 0 comments · Fixed by #2052
Assignees
@turt2live
Labels
client-server Client-Server API spec-bug Something which is in the spec, but is wrong
Projects
Matrix 1.0 workflow

Comments

@Sharparam
Copy link

Under the definition for PushCondition for API GET /_matrix/client/r0/pushrules/ it says the following for the property kind:

Required. One of: ["event_match", "contains_display_name", "room_member_count"]

However this is incorrect, it can have other values, at least: sender_notification_permission

This should be updated to reflect all possible values, or the type changed to string if it is not feasible or possible to list all possible values.
@turt2live turt2live added client-server Client-Server API spec-bug Something which is in the spec, but is wrong labels Apr 21, 2019
@turt2live turt2live added this to Nice to have bug/omission fixes in Matrix 1.0 workflow May 25, 2019
turt2live added a commit that referenced this issue May 29, 2019
@turt2live
Change reference for definition of push rule condition kinds
f9472ba 
Fixes #1970
@turt2live turt2live mentioned this issue May 29, 2019
Merged
@turt2live turt2live self-assigned this May 29, 2019
@turt2live turt2live moved this from Nice to have bug/omission fixes to In progress in Matrix 1.0 workflow May 29, 2019
Matrix 1.0 workflow automation moved this from In progress to Done Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
client-server Client-Server API spec-bug Something which is in the spec, but is wrong
Projects
No open projects
Matrix 1.0 workflow
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change reference for definition of push rule condition kinds matrix-org/matrix-spec-proposals
2 participants
@Sharparam @turt2live