Add missing punctuation #1991
Merged
Add missing punctuation #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
May 8, 2019
There was a problem hiding this comment.
please add a changelog entry which has words that resemble https://github.com/matrix-org/matrix-doc/blob/master/changelogs/client_server/newsfragments/1838.clarification (except in the right directories)
|
I've added a changelog with similar texts in both cs and ss directories, but will that still merge together? Should they be slightly different? |
|
They merge together in their respective specifications: This is the first instance of the s2s spec getting it, so it'll be lonely for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other small sentences are postfixed with a period. Add period to keep consistency.