Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should specify which servers must sign events #2074

Closed
richvdh opened this issue Jun 4, 2019 · 3 comments · Fixed by #2081
Closed

we should specify which servers must sign events #2074

richvdh opened this issue Jun 4, 2019 · 3 comments · Fixed by #2081
Assignees
Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)

Comments

@richvdh
Copy link
Member

richvdh commented Jun 4, 2019

We do not seem to specify which server(s) must have signed an event for it to be considered valid

@richvdh
Copy link
Member Author

richvdh commented Jun 4, 2019

I'm not really sure if this belongs under Checks performed on receipt of a PDU, Validating hashes and signatures, or even Checking for a signature in the appendix, but it ought to be somewhere.

@turt2live
Copy link
Member

I'd probably vote for the first two, maybe one referencing the other.

@turt2live turt2live added clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation) labels Jun 4, 2019
@turt2live turt2live added this to To add to spec in Matrix 1.0 workflow via automation Jun 4, 2019
@richvdh
Copy link
Member Author

richvdh commented Jun 4, 2019

The rules are something like:

  • for all events except invite events in response to a 3pid invite, the event must be signed by the server whose server name is in the sender of the event
  • for room v1-v2, the event must be signed by the server in the event_id, where that is different.

See https://github.com/matrix-org/synapse/blob/aa530e68005d041ad037b081fe748d301a11291a/synapse/federation/federation_base.py#L213.

@turt2live turt2live self-assigned this Jun 6, 2019
@turt2live turt2live moved this from To add to spec to In progress in Matrix 1.0 workflow Jun 6, 2019
Matrix 1.0 workflow automation moved this from In progress to Done Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants