Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec incorrectly claims that PUT /_matrix/federation/v1/send/{txnId} response has a [200, ...] wrapper #2236

Closed
turt2live opened this issue Aug 16, 2019 · 1 comment · Fixed by #2560
Closed

spec incorrectly claims that PUT /_matrix/federation/v1/send/{txnId} response has a [200, ...] wrapper #2236

turt2live opened this issue Aug 16, 2019 · 1 comment · Fixed by #2560
Assignees
@turt2live
Labels
s2s Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong

Comments

@turt2live
Copy link
Member

this is a bug. See #1802 (comment)
@turt2live turt2live added spec-bug Something which is in the spec, but is wrong s2s Server-to-Server API (federation) labels Aug 16, 2019
@turt2live turt2live mentioned this issue Aug 16, 2019
Merged
@richvdh richvdh changed the title s2s /send wrongly says the transaction is wrapped in an array spec incorrectly claims that PUT /_matrix/federation/v1/send/{txnId} response has a [200, ...] wrapper May 20, 2020
@richvdh richvdh mentioned this issue May 20, 2020
Closed
@richvdh
Copy link
Member

richvdh commented May 20, 2020 •
edited

Unlike the other endpoints mentioned in #1418 / MSC1802, this is a spec bug: PUT /_matrix/federation/v1/send does not have a [200, ...] wrapper in the response.

@turt2live turt2live self-assigned this May 20, 2020
turt2live added a commit that referenced this issue May 20, 2020
@turt2live
Fix the response format of the /send endpoint
74b627a 
Fixes #2236
@turt2live turt2live mentioned this issue May 20, 2020
Merged
@turt2live turt2live mentioned this issue May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
s2s Server-to-Server API (federation) spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the response format of the /send endpoint matrix-org/matrix-spec-proposals
2 participants
@turt2live @richvdh