Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2S request authentication unclear about destination to sign #2512

Closed
auscompgeek opened this issue Apr 23, 2020 · 0 comments · Fixed by #2570
Closed

S2S request authentication unclear about destination to sign #2512

auscompgeek opened this issue Apr 23, 2020 · 0 comments · Fixed by #2570
Assignees
@turt2live
Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)

Comments

@auscompgeek
Copy link
Contributor

Should the destination field be set to the server_name, or the Host header's value in the case of delegation?
@turt2live turt2live added clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation) labels Apr 23, 2020
@turt2live turt2live self-assigned this May 25, 2020
turt2live added a commit that referenced this issue May 25, 2020
@turt2live
Clarify which server names to sign requests with
b876ac5 
Fixes #2512
@turt2live turt2live mentioned this issue May 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
clarification An area where the spec could do with being more explicit s2s Server-to-Server API (federation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify which server names to sign requests with matrix-org/matrix-spec-proposals
2 participants
@auscompgeek @turt2live