New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial spec of SSSS #2597
initial spec of SSSS #2597
Conversation
@@ -0,0 +1 @@ | |||
Document Secure Secret Storage and Sharing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the later blog post, would help to have this reference the MSC(s) it implements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm!
specification/modules/secrets.rst
Outdated
<https://en.bitcoin.it/wiki/Base58Check_encoding#Base58_symbol_chart>`_, | ||
that is, using the alphabet | ||
``123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz``. | ||
4. A space should be added after every 4th character. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to say 'formatted into groups of four characters separated by spaces' lest someone think they're required to put a space at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm currently looking into implementing the SSSS part for Nheko. For that I usually prefer to look at explicit tables, i.e. like for the key types in the current spec already. This still seems to a bit vague at times here with just examples visualizing the structure, which makes it a bit hard to declare the corresponding structs in static languages. I think this could also use some clarification around which base64 is used where, i.e. what padding and url-safe and unsafe. Those tend to be pitfalls I fall in the most, and I prefer avoiding them. :D
Otherwise I'll see, how far I can get from the current text and I may have some more targeted feedback in the future. I think this could also be a good way to explore MSC2618, since Soru also wrote a (maybe not 100% complete) guide for this already.
Spec PR for #1946 / #2472
Rendered