Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial spec of SSSS #2597

Merged
merged 4 commits into from Jun 20, 2020
Merged

initial spec of SSSS #2597

merged 4 commits into from Jun 20, 2020

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jun 2, 2020

Spec PR for #1946 / #2472

Rendered

@uhoreg uhoreg requested a review from a team June 2, 2020 02:33
@@ -0,0 +1 @@
Document Secure Secret Storage and Sharing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the later blog post, would help to have this reference the MSC(s) it implements.

@turt2live turt2live requested a review from a team June 2, 2020 02:36
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm!

<https://en.bitcoin.it/wiki/Base58Check_encoding#Base58_symbol_chart>`_,
that is, using the alphabet
``123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz``.
4. A space should be added after every 4th character.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to say 'formatted into groups of four characters separated by spaces' lest someone think they're required to put a space at the end.

Copy link
Contributor

@deepbluev7 deepbluev7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm currently looking into implementing the SSSS part for Nheko. For that I usually prefer to look at explicit tables, i.e. like for the key types in the current spec already. This still seems to a bit vague at times here with just examples visualizing the structure, which makes it a bit hard to declare the corresponding structs in static languages. I think this could also use some clarification around which base64 is used where, i.e. what padding and url-safe and unsafe. Those tend to be pitfalls I fall in the most, and I prefer avoiding them. :D

Otherwise I'll see, how far I can get from the current text and I may have some more targeted feedback in the future. I think this could also be a good way to explore MSC2618, since Soru also wrote a (maybe not 100% complete) guide for this already.

specification/modules/secrets.rst Outdated Show resolved Hide resolved
specification/modules/secrets.rst Show resolved Hide resolved
@uhoreg uhoreg requested a review from a team June 11, 2020 20:21
@uhoreg uhoreg merged commit 83e4d8c into matrix-org:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants