Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove m.login.token and m.login.oauth2 UIA types #2609

Merged
merged 3 commits into from Jul 28, 2020
Merged

Remove m.login.token and m.login.oauth2 UIA types #2609

merged 3 commits into from Jul 28, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 4, 2020

AFAIK these have never been implemented. oauth2 lacks enough info to be sensibly implemented, and m.login.token just doesn't make sense.

@richvdh
Remove m.login.token and m.login.oauth2 UIA types
7c6636a 
AFAIK these have never been implemented. oauth2 lacks enough info to be
sensibly implemented, and `m.login.token` just doesn't make sense.
@richvdh
changelog
d9f9706
@richvdh richvdh requested a review from a team June 4, 2020 22:00
@turt2live
Copy link
Member

Surely this needs an MSC regardless of whether or not the thing is implemented in popular servers? It certainly feels extremely wrong to just remove something that's been in the spec for a while without giving people a chance to say "actually, I use this".

@richvdh
Copy link
Member Author

richvdh commented Jun 5, 2020

OH FINE

#2610, #2611.

@richvdh richvdh removed the request for review from a team June 5, 2020 09:56
turt2live
turt2live approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for when the other MSC clears in 115 seconds.

changelogs/client_server/newsfragments/2609.removal Outdated
@@ -0,0 +1 @@
Remove unimplemented `m.login.oauth2` and `m.login.token` user-interactive authentication mechanisms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RST

@turt2live turt2live merged commit 012f0b1 into master Jul 28, 2020
@richvdh
Copy link
Member Author

richvdh commented Jul 28, 2020

thanks!

@wbamberg wbamberg mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richvdh @turt2live