Remove room_id from /sync examples #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepbluev7
force-pushed
the
sync-example-fixes
branch
from
9151cb7
to
53d6c8d
Compare
turt2live
reviewed
Jun 11, 2020
deepbluev7
force-pushed
the
sync-example-fixes
branch
from
53d6c8d
to
e3d12d6
Compare
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should also be more explicit in the documentation for the sync endpoint, but I'm not sure, how to do that. One way would be to add a note box with "Be aware, that events returned by this endpoint do not include a room_id since that would duplicate the
room_id-> Room mapping."Signed-off-by: Nicolas Werner nicolas.werner@hotmail.de