Clarifications to the push module #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/push_clarifications
branch
from
f848a60
to
cc966cc
Compare
the default rules have conditions, so we need to define them first.
richvdh
force-pushed
the
rav/push_clarifications
branch
from
cc966cc
to
400b6df
Compare
ara4n
reviewed
Jun 16, 2020
|
lgtm, although I wonder if we should incorporate more of my 'rationale block' from the summary I wrote the other day at https://docs.google.com/document/d/1Fnh8sT_8hmWAZ_Yh9NaB8HI5occNfR4KyQ_NVdnXJzo/edit. It's definitely an improvement tho. |
sorry, I'm not immediately finding anything matching the description of a "rationale block" there. I'm going to go ahead and land this. we can always iterate on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are all just clarifications rather than changes.
Proabably easier to review the commits individually.