various key backups fixes #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
changed the title
|
Sorry, Travis. I decided to roll all the fixes into this PR. |
turt2live
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: starting at https://13733-24998719-gh.circle-artifacts.com/0/scripts/gen/client_server/unstable.html#put-matrix-client-r0-room-keys-keys-roomid-sessionid
GET /room_keys/keysrequired [1]GET/PUT/_matrix/client/r0/room_keys/keys/format correct[1]Thanks to nico for noticing.
The other
GET /room_keys/keys/*endpoints already had it marked as required, but apparently not this one. It seems the MSC did say that it was optional, although that doesn't make any sense because you can't decrypt the backup without knowing which version it belongs to, and nothing that's returned doesn't tell you the endpoint. The synapse implementation treats it as required.