Make translations for SAS emoji available in-tree #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 1.6% (1 of 64 strings) Translation: matrix-doc/SAS Emoji v1 Translate-URL: https://translate.riot.im/projects/matrix-doc/sas-emoji-v1/en_EN/
…-emoji-v1 Update from Weblate
…-emoji-v1 Update from Weblate
…-emoji-v1 Update from Weblate
This was referenced Aug 12, 2020
uhoreg
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2070
It's probably best to review this as a diff rather than as commits, due to this branch being used for experimentation. See included documentation for changes.
Client developers
The
data-definitions/sas-emoji.jsonfile will have a new property:translated_descriptions. This is a map of language to translateddescription. For example (not accurate):{ "number": 3, "emoji": "🐎", "description": "Horse", "unicode": "U+1F40E", "translated_descriptions": { "fr_FR": "Cheval" } }There's also a bunch of raw i18n files in the
data-definitionsdirectory, if you prefer.These files are intended to be updated somewhat regularly, with the bare minimum being at least once a release.