Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client_secret examples so that they are valid #2985

Merged
merged 3 commits into from
May 5, 2021

Conversation

anoadragon453
Copy link
Member

The regex of allowed characters for a client_secret parameter is [0-9a-zA-Z.=_-] (ref).

This PR updates the client_secret spec examples, which currently include an invalid character (an apostrophe).

@turt2live
Copy link
Member

The spec is in a code freeze so this will not be merged until the new platform is deployed. Apologies for the merge conflicts you'll have to deal with :)

@turt2live turt2live removed their request for review January 26, 2021 17:30
@anoadragon453 anoadragon453 requested a review from a team April 19, 2021 15:02
@anoadragon453
Copy link
Member Author

The spec is no longer in code freeze \o/

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIPIT

@anoadragon453 anoadragon453 merged commit a04d103 into master May 5, 2021
@anoadragon453 anoadragon453 deleted the anoa/correct_client_secret_examples branch May 5, 2021 10:47
richvdh pushed a commit that referenced this pull request Aug 23, 2021
The regex of allowed characters for a `client_secret` parameter is `[0-9a-zA-Z.=_-]`.

This PR updates the `client_secret` spec examples, which currently include an invalid character (an apostrophe).
richvdh pushed a commit that referenced this pull request Aug 27, 2021
The regex of allowed characters for a `client_secret` parameter is `[0-9a-zA-Z.=_-]`.

This PR updates the `client_secret` spec examples, which currently include an invalid character (an apostrophe).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants