Use the same domain for room ID and avatar URL. #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincox
approved these changes
Apr 13, 2021
turt2live
approved these changes
Apr 14, 2021
|
Thanks for adding a changelog @turt2live! 👍 |
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
Use the same domain for room ID and avatar URL.
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
Use the same domain for room ID and avatar URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that same of the examples had an avatar URL pointing to
bleeker.street, but an ID pointing tobleecker.street, seems these should be the same?