Fix user ID examples in direct_to_device schema #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
requested changes
Apr 16, 2021
There was a problem hiding this comment.
This looks to good to me, nice find!
Last thing to do is just the contributing boilierplate. Could you please include a changelog for server_server (I'd go with 3128.clarification) and sign off on your change.
Thanks!
|
(changes like this don't need signoff, and typically we just write changelogs for this sort of thing to take the burden off contributors) |
turt2live
approved these changes
Apr 16, 2021
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
Fix user ID examples in direct_to_device schema
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
Fix user ID examples in direct_to_device schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this while copy/pasting examples as tests in Ruma.