Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe social-sign-on (multiple SSO providers) #3163

Merged
merged 7 commits into from May 4, 2021
Merged

Describe social-sign-on (multiple SSO providers) #3163

merged 7 commits into from May 4, 2021

Conversation

turt2live
Copy link
Member

Spec for MSC2858

@turt2live turt2live requested a review from a team May 1, 2021 06:50
clokep
clokep reviewed May 3, 2021
View reviewed changes
content/client-server-api/modules/sso_login.md Outdated Show resolved Hide resolved
content/client-server-api/modules/sso_login.md Outdated Show resolved Hide resolved
content/client-server-api/modules/sso_login.md Show resolved Hide resolved
data/api/client-server/definitions/sso_login_flow.yaml Outdated Show resolved Hide resolved
informal/idp-brands.md Outdated Show resolved Hide resolved
turt2live and others added 3 commits May 3, 2021 08:21
@turt2live @clokep
Apply suggestions from code review
641d2ad 
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
@turt2live
Clarify provider naming
e6245f6
@turt2live
Clarify render approach
67b62cf
@turt2live turt2live requested a review from clokep May 3, 2021 14:23
clokep
clokep approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making those changes!

uhoreg
uhoreg approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pedantry, but otherwise lgtm

content/client-server-api/modules/sso_login.md Outdated Show resolved Hide resolved
data/api/client-server/definitions/sso_login_flow.yaml Outdated Show resolved Hide resolved
data/api/client-server/definitions/sso_login_flow.yaml Outdated Show resolved Hide resolved
informal/idp-brands.md Outdated Show resolved Hide resolved
@turt2live @uhoreg
Apply suggestions from code review
70d9deb 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@turt2live turt2live merged commit ab0c773 into master May 4, 2021
@turt2live turt2live deleted the travis/spec/msc2858-multisso branch May 4, 2021 01:35
richvdh pushed a commit that referenced this pull request Aug 23, 2021
@turt2live @richvdh
Merge pull request #3163 from matrix-org/travis/spec/msc2858-multisso
043bb53 
Describe social-sign-on (multiple SSO providers)
richvdh pushed a commit that referenced this pull request Aug 27, 2021
@turt2live @richvdh
Merge pull request #3163 from matrix-org/travis/spec/msc2858-multisso
c11efb3 
Describe social-sign-on (multiple SSO providers)
@richvdh richvdh mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

@uhoreg uhoreg uhoreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turt2live @clokep @uhoreg