Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that email handling converts to lowercase first #3167

Merged
merged 3 commits into from May 3, 2021

Conversation

turt2live
Copy link
Member

Spec for #2265

@turt2live turt2live requested a review from a team May 2, 2021 03:34
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, but otherwise lgtm

@turt2live turt2live merged commit 2119b5e into master May 3, 2021
@turt2live turt2live deleted the travis/spec/msc2265-lower-3pid branch May 3, 2021 05:11
@@ -772,6 +772,13 @@ Represents E-Mail addresses. The `address` is the raw email address in
`user@domain` form with the domain in lowercase. It must not contain
other text such as real name, angle brackets or a mailto: prefix.

In addition to lowercasing the domain component of an email address,
implementations are expected to lowercase the localpart as described
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase != casefold.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a request to fix it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

richvdh pushed a commit that referenced this pull request Aug 23, 2021
Specify that email handling converts to lowercase first
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Specify that email handling converts to lowercase first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants